This repository was archived by the owner on Aug 27, 2025. It is now read-only.
[master] Feature/scilla ext reads contract params#3337
Closed
Conversation
Contributor
|
Author
|
The attached zip file remote_reads_contract_params_tests.zip contains a set of suggested regression tests, to be used as follows:
None of the transitions make changes to the contract states, so it should be possible to deploy the contracts once and invoke all the transitions one by one. There is no need to redeploy between each transition invocation. Note that I have not been able to test the contracts, so it is possible that I have made a mistake when writing them. If you encounter an exception, then the first thing to do is to make sure that the Scilla code actually does what it's supposed to. |
Contributor
|
This is ancient and is likely never to be merged; closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Scilla needs to be able to query data from init files using the external reads system. This PR implements the changes needed on the C++ side of the queries and responses.
The PR is coupled to Zilliqa/scilla#1220. The changes in this PR and the changes in the Scilla PR are logically linked, and must be tested and released together.
Backward Compatibility
Review Suggestion
Status
Implementation
ProtoScillaQuery has been updated.
The actual reading of init data is currently only available in pseudo-code.
Integration Test (Core Team)